feat(fdo): register the device using FDO#554
Draft
joshuachp wants to merge 1 commit intoastarte-platform:masterfrom
Draft
feat(fdo): register the device using FDO#554joshuachp wants to merge 1 commit intoastarte-platform:masterfrom
joshuachp wants to merge 1 commit intoastarte-platform:masterfrom
Conversation
acc9a04 to
37f4c04
Compare
37f4c04 to
4e55f26
Compare
b9a1813 to
37286fd
Compare
harlem88
requested changes
Apr 7, 2026
0382d85 to
b5dd6ea
Compare
b5dd6ea to
3234ee7
Compare
This will expose the configuration methods and structure to register a device using the FIDO Device Onboarding protocol. Signed-off-by: Joshua Chapman <[email protected]>
3234ee7 to
99a91da
Compare
harlem88
approved these changes
Apr 7, 2026
lucaato
approved these changes
Apr 8, 2026
| Error::new(ErrorKind::Invalid, "pairing api client") | ||
| })?; | ||
|
|
||
| let _creds = provider.retrieve_credentials(&api).await.map_err(|error| { |
Contributor
There was a problem hiding this comment.
Is this here to test preemptively that the credential secret work ? In that case I would add a comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.